Refactor To Remove Code Duplication?
Feb 1, 2011
This is a simplified version of a class that I have in my project. Since the Bonus is figured the exact same way in each function I want to remove the obvious code duplication that appears here and make the three different functions into one. However I am not sure how to provide the argument that this new function would require.
For instance I am currently just passing the argument like this from code
lblVolumeBonus.Content = TestClass.VolumeBonusAmountStore(bonus).
I think I have to basically turn this logic around and call it with something like
lblVolumeBonus.Content = TestClass.VolumeBonusAmountStore(BonusTrackerBO.StoreBonus)
but I am not sure of the correct syntax or whether I am on the right track at all.
Public Class TestClass
Public Shared Function StoreBonus(ByVal bonus As BonusTrackerBO.StoreBonus) As Double
[Code]....
Edit: It may not make a difference but I should have made clear that there are other factors in the equation (I was just trying to keep it simple). So is the answer the same when there are other callbacks to the bonus like bonus.MaximumAmount, bonus.MinimumAmount? There are 5 callbacks to the bonus object and the amounts are different depending on whether it is a Store, District or Company asking.
View 2 Replies
ADVERTISEMENT
Jul 6, 2011
I am developing VB.Net application, here i am using DataGridView control to display data from database now it is displaying as follows
emp no emp name city Sal Description Salary
54 john NJ HRA 1000
54 john NJ DA 2500
54 john NJ BP 12500
but i need to display as follows
[Code]...
View 4 Replies
Aug 6, 2010
Am developing a resume data retrieving software where data is stored in one parent table and 4 child tables as such:
Resume_table ----> Parent table
holds ----> Res_ID, Emp_ID, Lang_ID, Task_ID & some other static data
Employee_Table--->which is referenced directly to Resume_Table.Emp_ID similarly ol other 3 tables are referenced to the main parent table Storing and retrieving data is all working fine as long as I am retrieving 1 record for each child tables But some times there might be couple of languages and only single records for other child tables.In dat case as the four child tables are ol in separate subreports whch are called onto the main report whch prints as cv gives redundancy in data i.e by giving duplication of ol records twice which were single records during entry, which i think follows the language table if it consist of 2 records.am using a join query to call these records onto crystal report...
[code]....
View 3 Replies
Jun 27, 2012
I have created a simply Pizza program (for a summer project not education related) that uses check boxes to determine what the customer wants. Basically a simple pizza ordering program.I was wondering as I have used the If statement over and other again for different parameters and variables, is it possible to use multiply arrays to simply the VB Code...I was advised to use Constructors in VB.Net Or is there a more simpler way to go about creating this program...or a better way of programing?What about decreasing the repetition in the code?
[code]...
View 4 Replies
Mar 2, 2009
Reading through "The Pragmatic Programmer", I've come across the DRY (Don't Repeat Yourself) and Orthagonal (keep code modular) principles.I have a suite of modules, some of which have common procedures. Because each module is a separate project in Visual Studio, up until now I have simply copied code from one project to another when 1 module (project) needs to do the same function as another module (project). This is when functionality overlaps, not when 2 modules (projects) do everything the same.
I always suspected this was bad practice (and have seen the fruits of my suspicions when the subs get out of sync), and the book confirmed me in this belief. So, what I want to do is make a central code repository for the 4 or 5 common subs, but I don't know how to do it.Should I make a .dll file for each sub I want to use in multiple places? If so, how do I do that? Is there another way to do what I want to do?
1. I have a subroutine that takes a filepath (and if disconnected also a SqlConnection) and loads the referenced file into a database as a BLOB.
2. I have 3 separate projects in 1 VS solution that all run basically the same version of this code.
3. I want all 3 to run EXACTLY the same code.
4. I want 1 version of this code so that any changes made don't need to be made in 3 places.
5. I have a few other instances like this for other subroutines.
View 8 Replies
Jun 5, 2011
i'm working on a voting system but im having problems in adding records... i have two a primary key, the idnumber and the address. the address is where I base if that certain address already voted. but the problem is everytime i try to add a record with the same address (ex. Block 1 lot 4), the data is duplicated which is not output i want. the program should detect that there is already an existing address.
[Code]...
View 3 Replies
Dec 13, 2009
I have this string just down loaded of a Unix server. I would like to remove the box (0x0A) Unix end line code; then replace it with CR+LF normal ASCII code. Also, I would like to do the replace before I save the data, while it in memory.
View 14 Replies
Feb 11, 2010
We have lots of WCF services that are only used by our own code; the code that uses them is mostly in the same solutions files that contains the services.
However they do not use a shared assembly for the contracts, so each time a data contract is change the reference to the service has to be updated by hand in all projects that use the service. (Then the code needs to be fixed up by hand)
So how do I do a simple refactoring like renamed a data item in a data contract?
Is there a way to update all references to services in a single solution with one command, rather then having to click on each reference in each project?
View 2 Replies
Jul 30, 2008
I downloaded and installed Refactor. The install worked fine and Refactor works in VS 2005. However, I also have VS 2008 installed and I cannot get Refactor to appear in that IDE. Is there something I need to do to get Refactor to appear in VS 2005 and VS 2008 on the same machine?
View 7 Replies
Feb 26, 2008
I was fooling around with the toolbars and noticed the Refactor section. So I made a toolbar with all of the refactor buttons and ... they don't do anything.I don't often customize so maybe I'm missing something.
View 6 Replies
Oct 17, 2011
I have the following line of code
Dim a As String = ""
And the Refactor suggests replacing the "" with String.Empty
It is a kind of Refactoring but why? Since I am a newbie in the future declarations of mine should I better use the String.Empty ?
View 5 Replies
Jul 17, 2009
how do I refactor all my instance variable to have all the get and set method? I tried RefactorVB but it seems like it can only refactor 1 by 1.
View 2 Replies
Aug 20, 2010
why visual Studio Does not have Refactor tool for vb.net by default ? but it has this tool for c#. for example extract method and etc.
View 2 Replies
Jul 3, 2009
Why doesn't vb.net in Visual Studio 2010 have any Refactor support
View 14 Replies
May 26, 2009
Assume you have controls A, B, C, D and E all with a Visibility property. You also have states 1,2,3,4,5 and 6 in which various combinations of your controls would be displayed. Currently this is being handled by switch statements for each state: i.e.
Select Case PageState
case "1"
a.visible = false
b.visible = true
[code]....
As you can imagine, this becomes a pain as every state needs a show/hide statement for each control. How can I refactor this so that adding controls and/or states becomes trivial?My first instinct is to extend the control and add a collection of states that it should display for but this sounds like overkill.
Edit:I was deliberately vague in my question in case this has other implications. In my current instance the "controls" in question are ASP Panels. Does that change anything?
View 4 Replies
Mar 23, 2011
Using ASP/VB, I'm trying to get rid of some duplication in a list box that is coming from an XML document.[code]...
View 1 Replies
Jan 13, 2009
In the below code I want to also check before inserting if that record exists or
Dim conn As New SqlConnection("xxxxx")
Try
conn.Open()
[code].....
View 1 Replies
Jun 19, 2009
Does anyone know how to duplicate the winforms databinding function - format in wpf? e.g. applying the format of #####0.00 to a text box?
View 3 Replies
Jul 21, 2010
I've gone through various thread, posts, classes and walkthroughs on sites but seem to be coming up short either in my understanding or what is/should be going on.I have a very simple data entry tabcontrol (think like microsoft excel but textboxes, labels and the odd combobox rather than a grid). When I click one tab it creates a new tab and names it according the sequence (no problems so far). Here is the crotch kicker (for me at least). I need the first tabpage layout on all additional tabpage so that data can be entered in each separately and stored with constant "processing" (adding and subtracting ).What would be the best approach to doing such a tabpage duplication?
Currently a User control library inheriting from tabpage seems like a good idea but with the 40 or so controls on it is this actually going to function like the first tabpage (as in the one i have now not the one I'd have if i used the user control instead).Do I take the raft of code the designer creates automatically for the tabpage and its controls and simply add them to the click event? Would this create duplication problems with name or would it be ok as they would be tabpage1.lblName and tabpage2.lblName?
View 4 Replies
May 23, 2011
i developed a project using VB.Net 2005 and sql server 2005 standard edition at back end. now its complete and have to deliver to company now. but i am afraid that the company may reproduce a new copy of this software from the original and may sell to any other company or in open market. I want to implement some mechanism on my project for its security, which enables it to not to work on other computers or some similar type security.
View 3 Replies
May 30, 2010
I have this code and it is not working correctly. Note: The code must check the if the data is valid every time the user enters a new datai have 2 columns in my table
Code:
Private Sub Table_CellValidated(ByVal sender As Object, ByVal e As Telerik.WinControls.UI.CellValidatedEventArgs) Handles Table.CellValidated
[code]....
View 2 Replies
Jun 12, 2011
I have a program connecting with a database.. so when add record in it, i want to validate for the duplication of ID in database..
here's my code for add button:
Private Sub cmdAdd_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles cmdAdd.Click
dSet.Tables(0).PrimaryKey = New DataColumn() {dSet.Tables(0).Columns("WatchID")} 'The table primary key is the WatchId
[Code]......
View 3 Replies
Nov 12, 2011
I'm writing a program on CD Collection. My problem is write a code that prevents a user to enter a CD collection name that is already stored in the filename.txt.
The rest of my program is okay, but the only problem is something do with btnAdd control.
Here's my whole program:
Option Explicit On
Option Strict On
Option Infer Off
[Code].....
View 14 Replies
Dec 21, 2011
However the error in this i why he is viewing pages on the same number of lines of SQL result 59]
ie he's reading every record and putting everyone on the same sheet, and in 59.
View 2 Replies
Feb 6, 2011
I am working on an application, where I have already normalized the databases. Now I am creating an application in asp.net with vb.net as my code behind fine. These random numbers would be stored in the Id column. So, no way there would be repeating the keys. But my application could generate the key, which would probably get repeated. How would I check the database for, so that random numbers wont get repeated? is there any function? Could you give me the code for the same.
View 10 Replies
Dec 7, 2009
I've got this problem. I have no clue how to prevent a duplicate from being entered in a combo box in VB2008. The information that is to be compared to is in a text file. What I have now works, but I have left out the prevent duplicate part.
[Code]...
View 1 Replies
Mar 28, 2011
i want to prevent user from adding same data on my database... (using access as database)
let say i have 5 fields on my database... ID, Name, address, contact, email... binded to textboxes... idTextbox, nameTextbox, addressTextbox, contactTextbox, emailTextbox.
if the user add a data.... and clicks the save button (saveButton) a messagebox will show a message saying that the data he/she entered already exist..
the messagebox will only show if the user entered a data with the same Name.
View 4 Replies
Sep 11, 2009
I am new to Visual studio 2008 using the express version. I wish to generate up to 10 000 random numbers without duplicates. Any appropriate container to store and print these numbers.
View 1 Replies
Jan 29, 2009
I'm trying to create a 'lottery machine', I've included the code i've been using below. I've got 7text boxes, ad numbers are between 1-49. I need to stop the duplication and to sort them in ascending order (1-49), i've tired a bubble sort but that hasn't worked, and a 'if, while' process, but i think it might be wrong! I know its a little pushy but i could do with this being sorted before 3pm friday 29 january 2009! I would be so greatful if anyone can even point me in the right direction as i am new to visual basic.
pixie_208
My code:
Public Class Form1
'version 27/01/2009
Dim Timer2Count As Integer
[code]....
View 1 Replies
May 23, 2011
i developed a project using VB.Net 2005 and sql server 2005 standard edition at back end. now its complete and have to deliver to company now. but i am afraid that the company may reproduce a new copy of this software from the original and may sell to any other company or in open market. I want to implement some mechanism on my project for its security, which enables it to not to work on other computers or some similar type security.
View 12 Replies
